Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

November 5th #1481

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

November 5th #1481

wants to merge 4 commits into from

Conversation

huumn
Copy link
Member

@huumn huumn commented Oct 17, 2024

So far this just introduces fee credits (aka cowboy credits) and makes it such that NON-p2p zaps increase the receiver's mcredit balance only.

In addition it refactors the interface of paidActions to export a priority ordered list of paymentMethods rather than booleans of supportsOptimism and supportsPessimism.

TODO

  • buy CCs directly (including with reward sats)
  • wallet settings page for all (CC settings, dust settings, etc)
  • notifications zaps when CC (shaming lack of attached wallet)
    • tbd if this will ship nov 5 as it requires denormalizing mcredits everywhere we do it for msats, e.g. stackedMcredits
  • how do we display CC zaps next to sat zaps
  • what to show in the navbar where sats used to go?
  • rewards sats pages (this will be exactly like the withdrawal page to start probably)
  • when zapper does not have a sending wallet, prioritize CC?

@riccardobl riccardobl mentioned this pull request Nov 7, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants