NDK

[riccardobl]

Description

Migrate nostr code to NDK.
I've kept it OOP like the original code.

• nwc sender
• nwc receiver
• crosspost
• zap note

closes #1549

Screenshots

Additional Context

Was anything unclear during your work on this PR? Anything we should definitely take a closer look at?

Checklist

Are your changes backwards compatible? Please answer below:
yes

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
zap notes are not tested by they should work™

For frontend changes: Tested on mobile? Please answer below:
n/a

Did you introduce any new environment variables? If so, call them out explicitly here:
no

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@nostr-dev-kit/[email protected]	network Transitive: environment, eval, filesystem	+26	4.84 MB	pablof7z

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Protestware or potentially unwanted behavior	npm/[email protected]	Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale	package-lock.json package.json	⚠︎
Protestware or potentially unwanted behavior	npm/[email protected]	Note: The script attempts to run a local post-install script, which could potentially contain malicious code. The error handling suggests that it is designed to fail silently, which is a common tactic in malicious scripts.	package-lock.json package.json	⚠︎

View full report↗︎

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/[email protected]

[riccardobl]

this is the global singleton, connections to specific relays are handled with RelaySets and their life cycle is left to ndk to handle

[riccardobl]

inject the wallet logger

[riccardobl]

Logging for nwc is a bit tricky because NDK abstracts away everything and uses npm:debug internally. I've got it to work by using a custom npm:debug logger that proxies to the wallet logger, but i am not sure if the verbosity is too high.