chore(wallet)_: returns last timestamps of successful GetWalletToken updates #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5988 +/- ##
===========================================
+ Coverage 60.97% 60.99% +0.02%
===========================================
Files 814 814
Lines 109253 109264 +11
===========================================
+ Hits 66619 66649 +30
+ Misses 34794 34782 -12
+ Partials 7840 7833 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saledjenic
approved these changes
Nov 1, 2024
dlipicar
reviewed
Nov 1, 2024
| @@ -137,6 +137,10 @@ func (api *API) GetWalletToken(ctx context.Context, addresses []common.Address) | |||
| return api.reader.GetWalletToken(ctx, clients, addresses, currency) | |||
| } | |||
|
|
|||
| func (api *API) GetLastWalletTokenUpdate() map[common.Address]time.Time { | |||
There was a problem hiding this comment.
we tend to use unix timestamps everywhere. What does a time.Time look like in JSON?
|
@friofry hi. Could you please rebase the current PR? Thanx! |
alwx
approved these changes
Nov 14, 2024
friofry
force-pushed
the
ab/issue-5987-last-token-update-time
branch
from
f9f96c9
to
9ea9bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
wallet/reader.gowe already have a mechanism to store timestamps when token info is updated inFetchBalancesandGetWalletToken.In this PR I just expose this map (address -> last update timestamp) to the API.
This should help @alwx with status-im/status-mobile#21401
Closed #5957