Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_: updated profile tests #6061

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

test_: updated profile tests #6061

wants to merge 1 commit into from

Conversation

churik
Copy link
Member

@churik churik commented Nov 8, 2024

Continuation of #6055

Based on info from settings_getSettings

Updated of these settings do not produce any new signals

Limitations are described here

@status-im-auto
Copy link
Member

status-im-auto commented Nov 8, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f1b760d #1 2024-11-08 12:42:22 ~4 min tests-rpc 📄log
✔️ f1b760d #1 2024-11-08 12:42:25 ~4 min linux 📦zip
✔️ f1b760d #1 2024-11-08 12:43:03 ~5 min windows 📦zip
✔️ f1b760d #1 2024-11-08 12:43:19 ~5 min android 📦aar
✔️ f1b760d #1 2024-11-08 12:44:47 ~6 min macos 📦zip
✔️ f1b760d #1 2024-11-08 12:45:41 ~7 min macos 📦zip
✔️ f1b760d #1 2024-11-08 12:48:00 ~10 min ios 📦zip
✔️ f1b760d #1 2024-11-08 13:12:09 ~34 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ db63d8b #2 2024-11-12 17:05:59 ~3 min windows 📦zip
✔️ db63d8b #2 2024-11-12 17:06:09 ~4 min tests-rpc 📄log
✔️ db63d8b #2 2024-11-12 17:06:26 ~4 min macos 📦zip
✔️ db63d8b #2 2024-11-12 17:06:28 ~4 min linux 📦zip
✔️ db63d8b #2 2024-11-12 17:06:52 ~5 min ios 📦zip
✔️ db63d8b #2 2024-11-12 17:07:20 ~5 min android 📦aar
✔️ db63d8b #2 2024-11-12 17:11:02 ~9 min macos 📦zip
✔️ db63d8b #2 2024-11-12 17:34:45 ~32 min tests 📄log
✔️ 0b00a8c #3 2024-11-12 17:13:44 ~3 min windows 📦zip
✔️ 0b00a8c #3 2024-11-12 17:14:03 ~4 min tests-rpc 📄log
✔️ 0b00a8c #3 2024-11-12 17:14:24 ~4 min macos 📦zip
✔️ 0b00a8c #3 2024-11-12 17:14:28 ~4 min linux 📦zip
✔️ 0b00a8c #3 2024-11-12 17:14:35 ~4 min ios 📦zip
✔️ 0b00a8c #3 2024-11-12 17:15:22 ~5 min android 📦aar
✔️ 0b00a8c #3 2024-11-12 17:19:07 ~7 min macos 📦zip
✔️ 0b00a8c #3 2024-11-12 18:08:20 ~33 min tests 📄log
✔️ 0b00a8c #4 2024-11-14 03:30:11 ~31 min tests 📄log

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.03%. Comparing base (1887b00) to head (0b00a8c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6061      +/-   ##
===========================================
+ Coverage    60.97%   61.03%   +0.05%     
===========================================
  Files          814      814              
  Lines       109253   109253              
===========================================
+ Hits         66619    66684      +65     
+ Misses       34794    34753      -41     
+ Partials      7840     7816      -24     
Flag Coverage Δ
functional 13.54% <ø> (-0.01%) ⬇️
unit 60.25% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 39 files with indirect coverage changes

@churik
Copy link
Member Author

churik commented Nov 11, 2024

closed #6070

("preview-privacy?", False, True),
("default-sync-period", 777600, 259200),
("appearance", 0, 1),
("profile-pictures-show-to", 2, 1), #obsolate from v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("profile-pictures-show-to", 2, 1), #obsolate from v1
# obsolete

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants