-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add region-helper functionality #81
Conversation
…tRegionName function
c83f51f
to
0a6838b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working very well, congratulations 🚀
@ademarCardoso thank you for your quick review, it is very much appreciated especially given that you are most likely very busy at the moment. If you have the time, would you please share some information on how to publish a new version of the CLI or what the release flow is? |
🎉 This PR is included in version 3.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hey @BibiSebi, it was released here: https://github.com/storyblok/storyblok-cli/releases/tag/v3.27.0 As soon as it got merged to the master branch, the But yeah, it's released 🙌 |
@BibiSebi Ping me on slack and i can share all the things 😄 I Already talked with @demetriusfeijoo about that |
This PR adds the new @storyblok/region-helper functionality and replaces the old way of managing the regions. This way there will be a single source of truth, which is the region-helper which will be consumed by other libraries and therefore will provide an easier and more stable way of dealing with regions.
Summary of additions:
Pull request type
Jira Link: EXT-2186
How to test this PR
This change is not supposed to modify any behavior but as
region
is widely used throughout the project, many commands can be impacted by it. So, as far as I have mapped here, the following commands are the ones that should be validated:So, for example, to test the
login with token
scenario, you should, from the root of the project, run:I've tested each of them and everything seemed to be working nicely, but a second view is always more than welcomed.
What is the new behavior?