Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove instantDebitsDeferredIntent feature flag #9635

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Nov 15, 2024

Summary

This pull request removes the instantDebitsDeferredIntent feature flag, as this will be released in next week’s release.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed           │          uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff   
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │   3.9 MiB │   3.9 MiB │ -49 B │   8.4 MiB │   8.4 MiB │ -100 B 
     arsc │   2.3 MiB │   2.3 MiB │   0 B │   2.3 MiB │   2.3 MiB │    0 B 
 manifest │     5 KiB │     5 KiB │   0 B │  24.9 KiB │  24.9 KiB │    0 B 
      res │ 902.3 KiB │ 902.3 KiB │   0 B │   1.4 MiB │   1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │   0 B │     6 MiB │     6 MiB │    0 B 
    asset │   1.6 MiB │   1.6 MiB │   0 B │   1.6 MiB │   1.6 MiB │    0 B 
    other │ 199.8 KiB │ 199.8 KiB │  -5 B │ 440.1 KiB │ 440.1 KiB │    0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │  11.4 MiB │  11.4 MiB │ -54 B │  20.2 MiB │  20.2 MiB │ -100 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 39838 │ 39837 │ -1 (+1 -2) 
   types │ 13743 │ 13743 │  0 (+0 -0) 
 classes │ 11435 │ 11435 │  0 (+0 -0) 
 methods │ 58697 │ 58697 │  0 (+0 -0) 
  fields │ 39010 │ 39009 │ -1 (+0 -1) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6190 │ 6190 │  0
APK
    compressed    │    uncompressed    │                                           
──────────┬───────┼───────────┬────────┤                                           
 size     │ diff  │ size      │ diff   │ path                                      
──────────┼───────┼───────────┼────────┼───────────────────────────────────────────
  3.9 MiB │ -49 B │   8.4 MiB │ -100 B │ ∆ classes.dex                             
   53 KiB │  -2 B │ 117.6 KiB │    0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │  -2 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA                       
 49.7 KiB │  -2 B │ 117.5 KiB │    0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │  +1 B │     120 B │    0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼───────┼───────────┼────────┼───────────────────────────────────────────
    4 MiB │ -54 B │   8.6 MiB │ -100 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   39838 │ 39837 │ -1 (+1 -2) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"91c36a6","r8-mode":"full","version":"8.7.14"}
  
  - IBP Deferred
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"3548fbb","r8-mode":"full","version":"8.7.14"}
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   39010 │ 39009 │ -1 (+0 -1) 
  
  - g5.d c: v

@tillh-stripe tillh-stripe force-pushed the tillh/remove-ibp-di-feature-flag branch from f96f516 to c4b2e26 Compare November 15, 2024 18:52
@tillh-stripe tillh-stripe marked this pull request as ready for review November 15, 2024 18:53
@tillh-stripe tillh-stripe requested review from a team as code owners November 15, 2024 18:53
@@ -15,7 +16,7 @@
## 21.0.0 - 2024-11-04

### PaymentSheet
- [CHANGED] [9498](https://github.com/stripe/stripe-android/pull/9498) The default value of `PaymentSheet.Configuration.Builder.paymentMethodLayout` has changed from Horizontal to Automatic.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these actually read better with a space.

@tillh-stripe tillh-stripe merged commit bb348ae into master Nov 15, 2024
16 checks passed
@tillh-stripe tillh-stripe deleted the tillh/remove-ibp-di-feature-flag branch November 15, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants