Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor error handling to use thiserror #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ahdinosaur
Copy link
Member

did as part of ssb-archive

  • changed error enums from using failure to using thiserror.
    • this changes what the functions return, previously failure::Error, now they return an error enum, e.g. FlumeOffsetLogError.
  • added error variants for source errors that were previously handled automatically
    • i decided to make specific variants for each situation, rather than for example just having an Io(#[from] std::io::Error) variant.
  • changed the FlumeLog trait to take an associated type Error.

open to feedback on the best way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant