Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generic argument from Histogram #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove generic argument from Histogram #103

wants to merge 1 commit into from

Commits on Sep 26, 2023

  1. Remove generic argument from Histogram 

    In swift-server#92, we added a Histogram that is generic over the observed type. This means that each Histogram was also carrying a generic argument. To work around this we created typealiases for `DurationHistogram` and `ValueHistogram`.

The motivation behind this was to preserve as much detailed information as possible. Duration can be more precise than Double. However in the grand scheme of things we now believe that this is overkill and a simpler to use Histogram type is more valuable. Thus this patch removes the generic argument from Histogram.
    @fabianfett
    fabianfett committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    00b0be4 View commit details
    Browse the repository at this point in the history