Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: make single-implementation concrete methods into abstract operations #3381

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jul 29, 2024

AOs are generally nicer for readers (and tooling).

I've left these where they were and just changed their type, but since each section is preceded by a sentence like

The behaviour of the additional concrete specification methods for Function Environment Records is defined by the following algorithms:

we should probably also either reword that sentence or move these somewhere else.

Commits can be reviewed individually but should land as a single commit.

@jmdyck
Copy link
Collaborator

jmdyck commented Jul 29, 2024

(Reading the commit titles, I wondered, "Why not HasRestrictedGlobalProperty?" But I see it's handled in the commit for CanDeclareGlobalVar.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants