Disable credentials persistence in Github checkout action #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
code | no functional change
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
martinhoyer
approved these changes
Oct 29, 2024
KwisatzHaderach
approved these changes
Oct 29, 2024
therazix
approved these changes
Oct 29, 2024
lukaszachy
approved these changes
Oct 29, 2024
psss
reviewed
Oct 30, 2024
psss
approved these changes
Oct 30, 2024
happz
added
the
status | ready for merge
happz
force-pushed
the
github-actions-persist-credentials
branch
from
7381b97
to
0da6deb
Compare
psss
force-pushed
the
github-actions-persist-credentials
branch
from
0da6deb
to
09a263e
Compare
According to a couple of articles, the default should be `false`, but it's not, which makes the token exposed to actions that do not need it. According to a linter I tried just for fun, we should enforce it to close this hole. [1] actions/checkout#485 [2] https://github.com/woodruffw/zizmor
psss
force-pushed
the
github-actions-persist-credentials
branch
from
09a263e
to
4186dfd
Compare
|
Checks, which are affected by this change are green, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to a couple of articles, the default should be
false, but it's not, which makes the token exposed to actions that do not need it. According to a linter I tried just for fun, we should enforce it to close this hole.[1] actions/checkout#485
[2] https://github.com/woodruffw/zizmor
Pull Request Checklist