Add int16 support to RELU #2727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddavis-2015
reviewed
Oct 19, 2024
| TF_LITE_MICRO_TEST(SimpleReluTestInt16) { | ||
| const int elements_count = 10; | ||
|
|
||
| int input_shape[] = {2, 1, 5}; |
ddavis-2015
reviewed
Oct 19, 2024
| int input_shape[] = {2, 1, 5}; | ||
| const float input_data[] = {1, 2, 3, 4, 5, -1, -2, -3, -4, -5}; | ||
| int16_t input_quantized[elements_count]; | ||
| int output_shape[] = {2, 1, 5}; |
ddavis-2015
reviewed
Oct 19, 2024
There was a problem hiding this comment.
In ReluPrepare the following code should be used to conform with TfLite (LiteRT):
if (input->type == kTfLiteInt8) {
CalculateReluOpData<int8_t>(input, output, data);
}
else if (input->type == kTfLiteInt16) {
TF_LITE_ENSURE_EQ(context, input->params.zero_point, 0);
TF_LITE_ENSURE_EQ(context, output->params.zero_point, 0);
CalculateReluOpData<int16_t>(input, output, data);
}
I am very surprised (and concerned) that the unit test passed, even though CalculateReluIOpData<int16_t> was not being called.
There was a problem hiding this comment.
It might have had something to do with the chosen input data values. I changed them so that they need to are actually int16 values and then the test failed. Could be just a coincidence that it happened to work or there might be something else going elsewhere
|
Thank you for submitting this PR. I have flagged the errors in the kernel and unit test above. On to @suleshahid for approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds int16 support to RELU
bug=#2726