Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for directory visiblity #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjadema
Copy link

@sjadema sjadema commented Feb 27, 2019

Added visibility when creating directories
Added a namespace for the unit tests
Added a test case for the new behaviour

Fixes #4

Added a namespace for the unit tests
Added a test case for the new behaviour
@sjadema
Copy link
Author

sjadema commented Mar 5, 2019

@twistor Bump! I really need this PR for my project <3

@twistor
Copy link

twistor commented Mar 9, 2019

What is the use case? Flysystem doesn't support visibility for lots of filesystems, so I'm not sure if this is a good idea.

@sjadema
Copy link
Author

sjadema commented Mar 9, 2019

I need an in-memory FS with directory support for https://github.com/twistor/flysystem-stream-wrapper. I've created an issue about a more defensive approach to the visibility Furthermore, the in-memory adapter is capable of directory visiblity (as it's capable of file visibility) so it wouldn't harm to add it imho.

@rulatir
Copy link

rulatir commented Nov 3, 2019

Is there any hope for this to ever be merged? If this comment has a chance of catching @twistor's attention - @twistor, do you still maintain flysystem-stream-wrapper?

@rulatir
Copy link

rulatir commented Nov 15, 2019

B
U
M
P

@Crell
Copy link

Crell commented Aug 14, 2024

Here's the issue: Often, the in-memory filesystem is used in tests for a system that will be using a non-memory filesystem in production. That means if the production filesystem ever wants to use is_dir(), you now cannot run tests, because the memory filesystem doesn't support it at present. This PR should, I think, resolve that issue, which is currently a blocker for elazar/flystream#9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visibility isn't passed to created directories
4 participants