debian/pam-configs/authd: Be stricter on failures #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If authd ignored the request, then we should ignore too. - If we can't connect to authd, we should ignore to select next method. - If we fail hard for other reason, then user should not be authenticated. Removed the handling of user_unknown case because we never return this from the PAM module for security reasons.
3v1n0
force-pushed
the
enhance-pam-config-handlers
branch
from
e8e142f
to
8f2569e
Compare
denisonbarbosa
requested changes
Mar 28, 2024
There was a problem hiding this comment.
These changes work when logging in with an authd user: great!
But they block login with a local one (possibly due to the previously discussed issues with gdm_authd not setting the previously selected broker correctly for the user): bad!!
This needs to wait until the mentioned issue is fixed.
|
that could be a good while, let’s stage this to see when we do trigger this error and see if we need to add it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the handling of user_unknown case because we never return this from the PAM module for security reasons.