Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pam/gdm): Implement JSON protocol in exec module and use it everywhere #292

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat(pam/gdm): Implement JSON protocol in exec module and use it everywhere #292

wants to merge 11 commits into from

Commits on Apr 11, 2024

  1. pam/gdm: Expose the proto message decoding function publicly 

    We may want to able to decode the value externally too, so let's make
this more visible
    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    39bb976 View commit details
    Browse the repository at this point in the history

  2. pam/gdm/extension: Add function to create JSON Protocol response 

    These are exposed as pam.BinaryconvResponse so no internal bit is
actually visible
    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    dc3f677 View commit details
    Browse the repository at this point in the history

  3. pam/dbusmodule: Add support for JSON binary conversations

    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c442f8f View commit details
    Browse the repository at this point in the history

  4. pam/go-exec: Add support for proxying JSON binary conversations 

    When a binary conversation is requested from the exec, start a JSON
binary conversation with GDM if such protocol is currently supported.

Add tests handling the conversation and all the possible corner cases
    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1746eec View commit details
    Browse the repository at this point in the history

  5. pam/integration-tests/gdm: Increase timeout and do not end Pam transa… 

    …ction in such case

If we're already about to fail because of a timeout don't cleanup the
transaction because we may end up stopping ongoing conversations which
will lead to a panic, without clear explaination
    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    e4bcbd0 View commit details
    Browse the repository at this point in the history

  6. pam/main-exec: Support running in GDM mode

    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    5bf70f6 View commit details
    Browse the repository at this point in the history

  7. pam/integration-tests: Run tests using the exec module with GDM too

    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1796980 View commit details
    Browse the repository at this point in the history

  8. debian/authd.gdm-authd: Use exec module for the GDM case 

    In this way we are consistent and we always use the same mode to run the
exec module, making possible to share module data in all the instances
    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    06ad9cb View commit details
    Browse the repository at this point in the history

  9. pam/integration-tests: Avoid re-entry on AcctMgmt if it has been alre… 

    …ady done
    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    01bcad3 View commit details
    Browse the repository at this point in the history

  10. pam: Drop go-loader 

    It's not used anymore so we can delete it
    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    623593c View commit details
    Browse the repository at this point in the history

  11. pam: Do not generate pam_authd.so by default

    @3v1n0
    3v1n0 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    69f706f View commit details
    Browse the repository at this point in the history