Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable dev-server package detection on windows #175

Merged
merged 1 commit into from
May 8, 2024

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented May 8, 2024

fixes #173

Bugfix

Disable dev-server package detection on windows as package is empty on that target

What is the current behavior?

Build fail on windows is including the runtime test package

What is the new behavior?

Build succeed

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb enabled auto-merge May 8, 2024 19:49
@dr1rrb dr1rrb merged commit fb4c153 into main May 8, 2024
6 checks passed
@dr1rrb dr1rrb deleted the dev/dr/fixBuildOnWindows branch May 8, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error compiling with Uno.Sdk SingleProject + Uno.UI.RuntimeTests.Engine on WinUI.
1 participant