DRAFT : For discussion only : Add a workaround for builtin calling conventions. #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for demonstration purposes of how we could perhaps work around builtin calling conventions by looking at the parameters of the builtin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is for demonstration purposes of how we could perhaps work around builtin calling conventions by looking at the parameters of the builtin.
Reason for change
SYCL Native CPU provides builtins which differ from what we expect using the spirv-unknown-unknown triple.
e.g. byval on the parameters
Description of change
Added
CreateBuiltinCallfunction which transforms the parameters if needed. Used on ShuffleUpDown function__mux_sub_group_shuffle_up_v*