Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add integrations and PHP (Laravel) docs #23

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

userquin
Copy link
Member

@userquin userquin commented Feb 8, 2023

No description provided.

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for vite-pwa-org ready!

Name Link
🔨 Latest commit efb3b8f
🔍 Latest deploy log https://app.netlify.com/sites/vite-pwa-org/deploys/63e3d840b8ec950008db6e19
😎 Deploy Preview https://deploy-preview-23--vite-pwa-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anburocky3
Copy link

@userquin Can i provide the example VitePWA() config in the bottom of the docs?

@anburocky3
Copy link

anburocky3 commented Feb 8, 2023

@userquin Regarding https://deploy-preview-23--vite-pwa-org.netlify.app/integrations/laravel.html#registering-service-worker

The service worker is injecting using this option and looks like we don't need to have it in app.ts to inject it using registerSW()

injectRegister: 'script',

@anburocky3
Copy link

@userquin I have made some changes, I couldn't push my commit.

image

@userquin
Copy link
Member Author

userquin commented Feb 8, 2023

you can add what you want, I just create the minimal to allow you start the docs without configuring VitePress: added some entries to the docs, feel free to change it

@anburocky3
Copy link

you can add what you want, I just create the minimal to allow you start the docs without confiring VitePress: added some entries to the docs, feel free to change it

Thank you, i changed few. But i couldn't push to this branch. Permission denied.

@userquin
Copy link
Member Author

userquin commented Feb 8, 2023

Permission denied.

Check my comment about this in the issue.

@anburocky3
Copy link

As you said, gave a PR here #24

@slavarazum
Copy link

Is it compatible with InertiaJS and Livewire, the two basic Laravel stacks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants