fix: vite build now works with broken symlink in public #18592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crutchcorn
force-pushed
the
fix-build-broken-symblink
branch
from
6427a65
to
5de6850
Compare
crutchcorn
changed the title
sapphi-red
requested changes
Nov 11, 2024
| @@ -598,6 +598,10 @@ export function copyDir(srcDir: string, destDir: string): void { | |||
| continue | |||
| } | |||
| const destFile = path.resolve(destDir, file) | |||
| // This may occur if the source directory is a symlink that points to a non-existent directory | |||
| if (!fs.existsSync(destFile)) { | |||
There was a problem hiding this comment.
I think this should be
Suggested change
| if (!fs.existsSync(destFile)) { | |
| if (!fs.existsSync(srcFile)) { |
Also I think it'd nice to avoid this existsSync call and add an try-catch to fs.statSync instead. fs.statSync throwed ENOENT on my machine (both Windows and WSL), did fs.statSync return a result on your machine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the problem of breaking
vite buildwhen having a broken symlink inside of thepublicfolder.This occurs because
stattreats symlinks asisDirectory() === trueand breaks with a "Not found" error when it attempts to copyA reproduction of this issue can be found here:
https://github.com/crutchcorn/broken-symblink-copy-demo