fix usage inside of stackblitz.com online IDE #58
+49
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
force-pushed
the
simon/stackblitz-support
branch
from
fbb97d9
to
4bfd724
Compare
WofWca
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Maybe it's just me being too out of the loop, but it's the first time I hear about WebContainers, so I personally would like to see some comments.
Also this includes unrelated formatting changes, but there is not a lot of them, so I guess it's fine.
Otherwise there aren't that many changes, it doesn't look like things are gonna break. And the feature itself is nice!
adbenitez
reviewed
Nov 16, 2024
backend/run.ts
Outdated
| import process from "process"; | ||
| import open from "open"; | ||
| import process from 'process'; | ||
| import open from 'open'; |
There was a problem hiding this comment.
it seems you used prettier which caused some noise in the PR, we should integrate prettier to avoid such styling issues
|
the code now is formatted with prettier, please rebase |
Simon-Laux
force-pushed
the
simon/stackblitz-support
branch
from
4bfd724
to
77d95f9
Compare
Simon-Laux
force-pushed
the
simon/stackblitz-support
branch
from
77d95f9
to
85fdb4c
Compare
WofWca
approved these changes
Nov 16, 2024
To clarify: IMU Prettier needs to be run before commit |
Co-authored-by: WofWca <[email protected]>
r10s
approved these changes
Nov 16, 2024
WofWca
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Because it could become a convenient way to develop webxdc apps without installing anything.
What does this?
detect if it is run in stackblitz, if yes it transforms urls to make it work.
What's next?
maybe also fix/add support other webIDE software like Github Codespaces.