Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Replace CreateMethodProperty with DefineMethodProperty #1390

Closed

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Mar 11, 2024

CreateMethodProperty was removed from ECMA262

Fixes #1389

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno: …
    • Node.js: …
    • webidl2.js: …
    • widlparser: …
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

CreateMethodProperty was removed from ECMA262
@lukewarlow lukewarlow requested a review from annevk March 11, 2024 18:06
@lukewarlow
Copy link
Member Author

I see this might get re-added to ECMAScript so will close this for now.

@lukewarlow lukewarlow closed this Mar 11, 2024
@ljharb
Copy link
Contributor

ljharb commented Mar 11, 2024

It won't; but I also filed #1391 for this. Feel free to use either one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CreateMethodProperty removed from Ecma262
2 participants