Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T369636: Fix border misalignment #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

T369636: Fix border misalignment #135

wants to merge 2 commits into from

Conversation

medied
Copy link
Contributor

@medied medied commented Nov 12, 2024

https://phabricator.wikimedia.org/T369636

Follow up to #134. QA feedback pointed to some weird rendering in the corners, after looking very closely I think indeed this border-radius is messing with the correct border rendering.

You really need to get your magnifying glass out to see this one, but I believe this is what was caught by QA:

with border-radius without border-radius
Before Image After Image
Before Image After Image

@medied
Copy link
Contributor Author

medied commented Nov 12, 2024

From phab description:

In darkmode, some whitespace is visible at the bottom of the preview

@stephanebisson can you still replicate the above with this branch? If so, could you please provide a screenshot for clarity?

@stephanebisson
Copy link
Contributor

From phab description:

In darkmode, some whitespace is visible at the bottom of the preview

@stephanebisson can you still replicate the above with this branch? If so, could you please provide a screenshot for clarity?

I fixed that part when I continued this work from Huei.

@medied
Copy link
Contributor Author

medied commented Nov 13, 2024

CI error seems to be related to npm, it's failing to complete the install and build step. Searching online recommends running npm cache clean --force which I'm trying in 96b00b6 but no luck yet. I can run npm install and npm build commands locally without an issue 🤔

@Nikerabbit
Copy link
Member

This is likely webpack/webpack#18963 / nodejs/node#55826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants