-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css: move overflow wrap rule to markdown.css
#1885
base: main
Are you sure you want to change the base?
css: move overflow wrap rule to markdown.css
#1885
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
@@ -40,7 +40,7 @@ h4, | |||
h5, | |||
h6, | |||
code { | |||
overflow-wrap: anywhere; | |||
background-color: rgba(255, 0, 0, 0.2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been through the entire doc, the only elements that are displayed in red (old rule) are the page main titles, and the "On this page" area (see https://starlight-git-fork-julien-deramond-main-jd-dc421d-astrodotbuild.vercel.app/getting-started/).
The search message error is probably not important, and the main title as well:
The rest in green works well.
One solution would probably be to keep that in markdown.css
and add specific rules for this main title and "On this page" area. What do you think @delucis? Want me to try this approach in this PR?
Description
This PR is a follow-up of what's been discussed in #1736 (review)
Basically, we move the
p ,h1, h2, h3, h4, h5, h6, code { overflow-wrap: anywhere; }
rule to themarkdown.css
.Temporarily, the red code shows the elements impacted by the previous rule, and the green one shows the elements impacted by the new rule.