Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade internal dependencies to Astro 5 #2603

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

natemoo-re
Copy link
Member

Description

This PR bumps internal dependencies on astro and @astrojs/markdoc to the upcoming Astro 5.0.0 release line (currently beta).

TBD on how this should be released:

  • Wait until 5.0.0 is stable and release as a new minor
  • Release as a beta of Starlight's next minor

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: d3370c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for astro-starlight failed. Why did it fail? →

Name Link
🔨 Latest commit d3370c8
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6734ce1b2a952c00081ee758

@github-actions github-actions bot added 🌟 core Changes to Starlight’s main package 🌟 markdoc Changes to Starlight’s Markdoc package labels Nov 13, 2024
@natemoo-re
Copy link
Member Author

Hmm, getting this error related to the MDX renderer move. Might be due to the dependency structure we're using where Starlight depends on the MDX integration directly.

[vite]: Rollup failed to resolve import "@astrojs/mdx/server.js" from "@astro-renderers".

@lilith
Copy link

lilith commented Nov 15, 2024

How soon do you think starlight will support Astro 5? I'm wondering how long I should wait to adopt it for a new docs site.

@delucis
Copy link
Member

delucis commented Nov 16, 2024

How soon do you think starlight will support Astro 5? I'm wondering how long I should wait to adopt it for a new docs site.

We’re actively working on it, but hard to say exactly. We’re certainly aiming to have a v5 compatible release ready in time for when Astro 5 is stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 markdoc Changes to Starlight’s Markdoc package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants