Replace NLBs on subnets change #610
Open
+71
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
force-pushed
the
move-nlb-subnet
branch
from
289170c
to
d198079
Compare
szuecs
reviewed
Jun 14, 2023
mikkeloscar
force-pushed
the
move-nlb-subnet
branch
from
d198079
to
86e397e
Compare
|
👍 |
|
Need to properly test it in a cluster before this is ready. |
mikkeloscar
force-pushed
the
move-nlb-subnet
branch
2 times, most recently
from
15951e8
to
f6a593f
Compare
|
This change doesn't yet work correctly. The problem is that when subnets are changed then the existing NLB stacks are updated with new subnets which is not possible and leads to those stack going into Rollback, this way they can't be successfully decommissioned. Solution is to ensure that once an NLB stack is created the subnets are never changed on updates. I will work on this when I find the time 😅 |
mikkeloscar
force-pushed
the
move-nlb-subnet
branch
from
f6a593f
to
65c2868
Compare
mikkeloscar
force-pushed
the
move-nlb-subnet
branch
2 times, most recently
from
4e96ce2
to
b29c0d3
Compare
szuecs
reviewed
Apr 17, 2024
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
move-nlb-subnet
branch
from
b29c0d3
to
fceb0ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an implicit feature to migrate NLBs when the subnets specified for the NLB changes.
This is done because for NLBs you can't change the subnets once the NLB has been created. This is unlike ALBs where you can freely change the subnets (and wait up to a week for it to take affect 🤷). This enables simple migration between subnets with the assumption that it's no problem to replace an NLB with a new one.
The way this works is that during the sync it checks if the existing managed NLBs have the subnets in sync. If not the NLB stack is ignored and the ingresses that were previously mapped to the NLB stack will now be mapped to a new one. The old NLB stack will become "empty" and after 1 hour (default) it will be cleaned up.