Feature/34 introduce unit tests for generator #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf8b45d.
…-Introduce-Unit-Tests-For-Generator
MobiTikula
requested review from
miroslavpojer and
Zejnilovic
as code owners
There was a problem hiding this comment.
- pulled
- local run
- unit test run
Missing tests: - action_input: I would cover three static methods by tests to check default values expected by documentation.
- github_projects: I would propose new issue to implement Integration test - testing current branch code for mining with full features enabled (result can be empty, it depends - it is not exact counting test)
| @@ -1,7 +1,7 @@ | |||
| [tool.black] | |||
| line-length = 120 | |||
| target-version = ['py311'] | |||
| force-exclude = '''test''' | |||
| #force-exclude = '''test''' | |||
There was a problem hiding this comment.
Suggested change
| #force-exclude = '''test''' | |
| force-exclude = '''test''' |
| mock_logger_info = mocker.patch("living_documentation_generator.generator.logger.info") | ||
| mock_logger_debug = mocker.patch("living_documentation_generator.generator.logger.debug") | ||
|
|
||
| issue_mock = mocker.Mock() |
There was a problem hiding this comment.
Suggested change
| issue_mock = mocker.Mock() | |
| mock_issue = mocker.Mock() |
There was a problem hiding this comment.
When mocking then keep the same format.
| project_issue_2 = mocker.Mock(spec=ProjectIssue) | ||
| project_issue_2.organization_name = "OrgA" | ||
| project_issue_2.repository_name = "RepoA" | ||
| project_issue_2.number = 1 |
There was a problem hiding this comment.
Suggested change
| project_issue_2.number = 1 | |
| project_issue_2.number = 2 |
There was a problem hiding this comment.
Here I am a little bit confused - Issue in same repo with two states? As I understand the test code you want to simulate two project issues for two issues right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests using Pytest for generator.py and main.py.
Release Notes:
Closes #34