-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use live runtime references for vcxproj #10028
base: main
Are you sure you want to change the base?
Conversation
77db438
to
038bc30
Compare
Unfortunately this doesn't work:
cc @ericstj as you might have ideas |
Submitted #10030 as a workaround until this PR gets in. |
That error is odd - I would expect that file to be opened for read only (since build processes should never write to such global files) - I wonder if NuGet is missing a sharing permission when opening this file? |
Fixes #9490 Unblocks dotnet/sdk#43015 When building wpf inside the VMR, a 10.0.100 SDK is used. WPF currently still targets net9.0. As WPF directly depends on runtime, it already uses 10.0.0-alpha versions of the targeting and runtime packs for managed projects. Enable this for vcxprojs as well so that the host packages can also be restored from the flowing runtime dependency. Fixes errors like these: > The Apphost pack is not installed and NuGet package restore is not supported. Upgrade Visual Studio, remove global.json if it specifies a certain SDK version, and uninstall the newer SDK. For more options visit https://aka.ms/targeting-apphost-pack-missing Pack Type:Apphost, Pack directory: D:\a\_work\1\vmr\.dotnet\packs\Microsoft.NETCore.App.Host.win-x64, targetframework: net9.0, Pack PackageId: Microsoft.NETCore.App.Host.win-x64, Pack Package Version: 9.0.0-rc.2.24473.5
038bc30
to
601f3c5
Compare
Others are hitting this as well in different repos. We have an offline conversation going about this. This seems to be Defender related. @ericstj I'm not sure how to avoid the current failures. It looks like the vcxprojs use the net9.0-windows7.0 TFM but everything else just uses the net9.0 TFM. Any idea whether the vcxprojs need to use that TargetPlatformMoniker? Unsure if there's a better person to ask this. |
Fixes #9490
Unblocks dotnet/sdk#43015
When building wpf inside the VMR, a 10.0.100 SDK is used. WPF currently still targets net9.0. As WPF directly depends on runtime, it already uses 10.0.0-alpha versions of the targeting and runtime packs for managed projects.
Enable this for vcxprojs as well so that the host packages can also be restored from the flowing runtime dependency.
Fixes errors like these:
Fixes #
Main PR
Description
Customer Impact
Regression
Testing
Risk
Microsoft Reviewers: Open in CodeFlow