feat(datatypes): allow trailing comma in struct string shorthands #10393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
cpcloud
reviewed
Oct 30, 2024
Now, `dt.dtype("struct<a: int32, b: string,>")` is allowed
cpcloud
force-pushed
the
dt-parse-trailing-comma
branch
2 times, most recently
from
03d5609
to
6662f7f
Compare
cpcloud
force-pushed
the
dt-parse-trailing-comma
branch
from
6662f7f
to
5122028
Compare
cpcloud
changed the title
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now,
dt.dtype("struct<a: int32, b: string,>")is allowed.Related to #10391, where when testing my example I got an error when I didn't think I should.