Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datatypes): allow trailing comma in struct string shorthands #10393

Merged
merged 3 commits into from
Oct 30, 2024
Merged

feat(datatypes): allow trailing comma in struct string shorthands #10393

merged 3 commits into from
Oct 30, 2024

Commits on Oct 30, 2024

  1. feat(dt): allow trailing comma in struct string shorthands 

    Now, `dt.dtype("struct<a: int32, b: string,>")` is allowed
    @NickCrews @cpcloud
    NickCrews authored and cpcloud committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2cd97c1 View commit details
    Browse the repository at this point in the history

  2. fix(datatypes): disallow empty structs when parsing

    @cpcloud
    cpcloud committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5122028 View commit details
    Browse the repository at this point in the history

  3. chore: handle the empty struct case

    @cpcloud
    cpcloud committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    02df31c View commit details
    Browse the repository at this point in the history