feat: implement the standard library numeric functions. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only the calculated return type was returned from `Function::bind`. This change adds both the overload index and the bound function signature are returned as well. The index can then be used to statically dispatch the call in expression evaluation. Additionally, the minimum version has moved from being specified on the function to each individual signature. This will allow the standard to add overloads for existing functions in the future.
This commit implements call expressions for the following standard library functions: * `floor` * `ceil` * `round` * `min` * `max` Included with this change is a refactoring to how we evaluate call expressions in both analysis and the engine; this refactoring prevents an allocation in analysis and fixes a bug in the engine where the number of arguments to the function exceeded `MAX_PARAMETERS` and caused a panic.
peterhuene
commented
Nov 12, 2024
peterhuene
commented
Nov 12, 2024
a-frantz
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements call expressions for the following standard library
functions:
floorceilroundminmaxAdditionally, this PR refactors binding functions in
wdl-analysisto providemore information to allow for dispatching the call to the implementation in
wdl-engine.One of the bigger changes is that the minimum WDL version specification
for functions has moved from the function itself to the signatures; this
means that future versions of WDL can add a new overload to an existing
function and the new signature will not be included in the overload set
when evaluating for a previous version of WDL.
Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md(see"keep a changelog" for more information).