Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement the standard library numeric functions. #251

Merged
merged 4 commits into from
Nov 12, 2024
Merged

feat: implement the standard library numeric functions. #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a5c93d
refactor: return more information from `Function::bind`.
peterhuene Nov 11, 2024
bea45f8
feat: implement the standard library numeric functions.
peterhuene Nov 11, 2024
7e9bf71
chore: update gauntlet.
peterhuene Nov 12, 2024
233c682
chore: update CHANGELOG.md.
peterhuene Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,063 changes: 399 additions & 2,664 deletions Arena.toml
View file
Open in desktop

Large diffs are not rendered by default.

906 changes: 428 additions & 478 deletions Gauntlet.toml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions wdl-analysis/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

* Refactored function call binding information to aid with call evaluation in
`wdl-engine` ([#251](https://github.com/stjude-rust-labs/wdl/pull/251)).
* Made diagnostic creation functions public ([#249](https://github.com/stjude-rust-labs/wdl/pull/249)).
* Refactored expression type evaluator to provide context via a trait ([#249](https://github.com/stjude-rust-labs/wdl/pull/249)).
* Removed `PartialEq`, `Eq`, and `Hash` from WDL-type-related types ([#249](https://github.com/stjude-rust-labs/wdl/pull/249)).
Expand Down
2 changes: 1 addition & 1 deletion wdl-analysis/src/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ pub fn unknown_function(name: &str, span: Span) -> Diagnostic {
/// Creates an "unsupported function" diagnostic.
pub fn unsupported_function(minimum: SupportedVersion, name: &str, span: Span) -> Diagnostic {
Diagnostic::error(format!(
"function `{name}` requires a minimum WDL version of {minimum}"
"this use of function `{name}` requires a minimum WDL version of {minimum}"
peterhuene marked this conversation as resolved.
Show resolved Hide resolved
))
.with_highlight(span)
}
Expand Down
Loading